Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for the number of values and variables match in DATA #2822

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Add test for the number of values and variables match in DATA #2822

merged 2 commits into from
Nov 7, 2023

Conversation

HarshitaKalani
Copy link
Contributor

Fixes: #1991

@HarshitaKalani HarshitaKalani added the SciPy issues related to enable LFortran to compile the entire FORTRAN codebase in SciPy label Nov 7, 2023
@certik
Copy link
Contributor

certik commented Nov 7, 2023

Why not just making it an integration test?

I would only use "tests" if we need to test the ASR or other steps. If this fully works, then a full test is enough?

@HarshitaKalani
Copy link
Contributor Author

Oh sure, I'll do it.

@HarshitaKalani HarshitaKalani marked this pull request as ready for review November 7, 2023 14:30
certik
certik approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@certik certik merged commit f7bebd7 into lfortran:main Nov 7, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
SciPy issues related to enable LFortran to compile the entire FORTRAN codebase in SciPy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SciPy]: The number of values and variables do not match in DATA
2 participants
@HarshitaKalani @certik