Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle symbol import for templates, requirements #2838

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Handle symbol import for templates, requirements #2838

merged 4 commits into from
Nov 10, 2023

Conversation

ansharlubis
Copy link
Contributor

This allows compiling the set of modules described in #2814. But, there is still some problem with computations involving templated array, such as:

combined%elements(i, j) = sum(times_t(x%elements(i,:), y%elements(:,j)))

In matrix_m.f90. I made some changes to make it compilable.

@ansharlubis ansharlubis added the generics Fortran 202Y Generics label Nov 10, 2023
@ansharlubis ansharlubis self-assigned this Nov 10, 2023
@ansharlubis ansharlubis marked this pull request as ready for review November 10, 2023 15:46
@ansharlubis ansharlubis removed their assignment Nov 10, 2023
certik
certik approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, thanks!

@certik certik merged commit f345516 into lfortran:main Nov 10, 2023
20 checks passed
@ansharlubis ansharlubis deleted the issue-2814 branch December 12, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
generics Fortran 202Y Generics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ansharlubis @certik