Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string support for intrinsic min #2869

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Conversation

HarshitaKalani
Copy link
Contributor

No description provided.

@HarshitaKalani
Copy link
Contributor Author

I thought GFortran compares the strings' lengths and gives the minimum according to the lengths. I just checked again and it does it lexicographically. Will correct this soon.

Copy link
Member

@Thirumalai-Shaktivel Thirumalai-Shaktivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems correct.
LGTM!

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts should be resolved. Otherwise I think this is good to merge.

@HarshitaKalani HarshitaKalani marked this pull request as ready for review December 1, 2023 14:00
@certik certik merged commit 0a35430 into lfortran:main Dec 2, 2023
20 checks passed
@certik
Copy link
Contributor

certik commented Dec 2, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants