Fix deferred class procedure with nopass attribute #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASR: Provide is_nopass to set_absent_optional_arguments_to_null()
Shaikh-Ubaid
force-pushed
the
class_proc
branch
from
60cb71f
to
a043bdb
Compare
certik
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
I think that looks good,.
@Shaikh-Ubaid thanks for fixing these, this is extremely useful.
@difference-scheme, go ahead and test this.
|
@Shaikh-Ubaid @certik Thanks indeed! I am about to pull the changes and retest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2880