Remove the --run flag
#2931
Merged
Remove the --run flag
#2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is fine, but let me try to test it by hand first, since the modifications are quite extensive in the driver. |
src/bin/lfortran.cpp
Outdated
| if (0 < err && err < 256) { | ||
| return err; | ||
| } else { | ||
| return 1; |
There was a problem hiding this comment.
See: lcompilers/lpython#1352 (comment)
Suggested change
| return 1; | |
| return LCompilers::get_exit_status(err); |
src/bin/lfortran.cpp
Outdated
| } else { | ||
| LCOMPILERS_ASSERT(false); | ||
| return 1; | ||
| } | ||
|
|
||
| if (outfile != file_name + ".out" || compiler_options.arg_o != "") { |
There was a problem hiding this comment.
This is very rare case, but I think this might fail for the case lfortran x.f90 -o x.out, so let's only do?
Suggested change
| if (outfile != file_name + ".out" || compiler_options.arg_o != "") { | |
| if ( compiler_options.arg_o != "" ) { |
Shaikh-Ubaid
force-pushed
the
run_flag
branch
from
2dccf6f
to
64a8147
Compare
|
Ready. |
certik
reviewed
Dec 2, 2023
| std::string run_cmd = ""; | ||
| if (backend == Backend::wasm) { | ||
| // for node version less than 16, we need to also provide flag --experimental-wasm-bigint | ||
| run_cmd = "node --experimental-wasi-unstable-preview1 " + outfile + ".js"; |
There was a problem hiding this comment.
I don't know if we want to support all the wasm runtimes. I usually use wasmtime for example.
certik
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2833 (comment)