Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lapack example with generics #2963

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Lapack example with generics #2963

merged 3 commits into from
Dec 11, 2023

Conversation

ansharlubis
Copy link
Contributor

Addressing #2267. However, the example described in the issue didn't implement the specific subroutines sgemm, etc.

@ansharlubis ansharlubis added the generics Fortran 202Y Generics label Dec 10, 2023
@ansharlubis ansharlubis marked this pull request as ready for review December 10, 2023 12:58
certik
certik approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, thanks!

The idea is to link sgemm from Lapack directly.

@certik certik merged commit 65c48c7 into lfortran:main Dec 11, 2023
20 checks passed
@ansharlubis ansharlubis mentioned this pull request Dec 11, 2023
Open
37 tasks
@ansharlubis ansharlubis deleted the issue-2267-lapack branch December 11, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
generics Fortran 202Y Generics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ansharlubis @certik