Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface for operators in templates and templated functions #2973

Merged
merged 9 commits into from
Dec 19, 2023

Conversation

ansharlubis
Copy link
Contributor

Addressing issue #2508.

@ansharlubis ansharlubis added the generics Fortran 202Y Generics label Dec 14, 2023
@ansharlubis ansharlubis marked this pull request as ready for review December 14, 2023 13:39
@ansharlubis ansharlubis mentioned this pull request Dec 14, 2023
37 tasks
@@ -3123,7 +3141,7 @@ class SymbolTableVisitor : public CommonVisitor<SymbolTableVisitor> {
false, false, false, nullptr, 0, false, false, true);
ASR::symbol_t *op_sym = ASR::down_cast<ASR::symbol_t>(op_function);
parent_scope->add_symbol(func_name, op_sym);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove whitespace

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great, thank you for implementing this!

Remove that whitespace and rebase or squash before merging.

@ansharlubis ansharlubis enabled auto-merge (squash) December 19, 2023 02:46
@ansharlubis ansharlubis merged commit aa7bfa9 into lfortran:main Dec 19, 2023
21 checks passed
@ansharlubis ansharlubis deleted the issue-2508-template-interface branch December 19, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generics Fortran 202Y Generics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants