Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cxxflags #2975

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fix cxxflags #2975

merged 2 commits into from
Dec 15, 2023

Conversation

junghans
Copy link
Contributor

@junghans junghans commented Dec 15, 2023 •
edited

Fix #2974

CMake picks up CXXFLAGS automatically, so I am not sure what the point of 487ff2e was.

@junghans
Copy link
Contributor Author

@Shaikh-Ubaid please review.

Shaikh-Ubaid
Shaikh-Ubaid approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@Shaikh-Ubaid Shaikh-Ubaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thank you so much for the contributions! I appreciate it.

@Shaikh-Ubaid Shaikh-Ubaid merged commit d1644d9 into lfortran:main Dec 15, 2023
20 checks passed
@Shaikh-Ubaid Shaikh-Ubaid mentioned this pull request Dec 15, 2023
Merged
@junghans junghans deleted the fix_CXXFLAGS branch December 15, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaikh-Ubaid Shaikh-Ubaid Shaikh-Ubaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build breaks when CXXFLAGS contain white spaces
2 participants
@junghans @Shaikh-Ubaid