cmake: allow more CMAKE_BUILD_TYPE #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@certik ready for your review! |
|
PS: The "Check Out-of-Source Debug build" jobs in the CI isn't "required", but should. |
|
I added the out-of-source CI test to "required". |
certik
force-pushed
the
more_buildtypes
branch
from
6ad587d
to
0625bbe
Compare
certik
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
I think this is fine. I added those checks there to ensure either Debug or Release, but if things work, we can support more configurations. Note that this file https://github.com/lfortran/lfortran/blob/75cf687c5318f695d1526c3017a4e6576772310a/cmake/UserOverride.cmake probably also needs to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to build with
RelWithDebInfoand saw no reason why that wouldn't work, so allowing it in CMake now.