Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gamma to IntrinsicScalarFunction #3032

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Add gamma to IntrinsicScalarFunction #3032

merged 3 commits into from
Jan 4, 2024

Conversation

Thirumalai-Shaktivel
Copy link
Member

Fixes: #3019

@Thirumalai-Shaktivel Thirumalai-Shaktivel marked this pull request as draft January 3, 2024 14:40
@Thirumalai-Shaktivel Thirumalai-Shaktivel changed the title Bug: Fix name clashing with intrinsic function name Add gamma to IntrinsicScalarFunction Jan 4, 2024
@Thirumalai-Shaktivel Thirumalai-Shaktivel added the stdlib Issues related to compiling fortran-lang/stdlib label Jan 4, 2024
@Thirumalai-Shaktivel
Copy link
Member Author

Ready!

certik
certik approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks great, thanks!

@certik certik marked this pull request as ready for review January 4, 2024 19:02
@certik certik merged commit 0a42324 into lfortran:main Jan 4, 2024
21 checks passed
@Pranavchiku Pranavchiku mentioned this pull request Jan 5, 2024
Open
11 tasks
@Thirumalai-Shaktivel Thirumalai-Shaktivel deleted the stdlib_02 branch February 8, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
stdlib Issues related to compiling fortran-lang/stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: gamma had to be renamed to mgamma
2 participants
@Thirumalai-Shaktivel @certik