Simplify ASR.asdl #3063
Merged
Simplify ASR.asdl #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks good so far. |
|
We can move all the comments into After that, we can iteratively improve the documentation to move things around (split into individual nodes) and improve. |
certik
reviewed
Jan 9, 2024
certik
reviewed
Jan 10, 2024
certik
reviewed
Jan 10, 2024
certik
reviewed
Jan 10, 2024
|
I think this looks great. Fix up the conflicts and the few things I noticed, then we can merge and improve upon it later. |
|
Done! Thank you for all your prompt reviews in this PR :-) |
|
Thanks. One last thing: #3063 (comment). |
certik
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1900
TODO