Fix use of keyword args for intrinsic functions #3075
Conversation
|
Thanks for working on this, very helpful. |
HarshitaKalani
force-pushed
the
merge_02
branch
from
7101ec7
to
5e27957
Compare
| @@ -4196,7 +4196,7 @@ class CommonVisitor : public AST::BaseVisitor<Derived> { | |||
|
|
|||
| ASR::asr_t* create_ArraySize(const AST::FuncCallOrArray_t& x) { | |||
| Vec<ASR::expr_t*> args; | |||
| std::vector<std::string> kwarg_names = {"dim", "kind"}; | |||
| std::vector<std::string> kwarg_names = {"array", "dim", "kind"}; | |||
| handle_intrinsic_node_args(x, args, kwarg_names, 1, 3, std::string("size")); | |||
There was a problem hiding this comment.
Let's separate these changes into another PR. But would modify the handle_intrinsic_node_args function to rename kwarg_names to just arg_names which would list all arguments, and then the min/max arg number would still be 1, 3 in this case, and everything should work.
There was a problem hiding this comment.
Even later we can then refactor these to use the model in #3090.
There was a problem hiding this comment.
For example the function handle_intrinsic_node_args can just access the name2signature dictionary to access the information.
|
I made this a draft for now. Once you address #3075 (comment) then make it ready for review again. |
HarshitaKalani
force-pushed
the
merge_02
branch
from
5e27957
to
78404c0
Compare
HarshitaKalani
force-pushed
the
merge_02
branch
from
c59ef30
to
8955b40
Compare
|
@certik this is ready. Can you please review it? |
Fixes: #3053
Towards: #3052
With this PR, I'm handling the presence of keywords with the args in intrinsic functions - #3053 (comment)
This should help in resolving the issue while building
stdlib, however there are still changes that need to be done.