Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stdlib: LFortran compiles ascii #3095

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Stdlib: LFortran compiles ascii #3095

merged 1 commit into from
Jan 13, 2024

Conversation

Shaikh-Ubaid
Copy link
Member

@Shaikh-Ubaid Shaikh-Ubaid commented Jan 12, 2024 •
edited

LFortran Output:

+ ./example/ascii/example_ascii_reverse
!dlroW ,olleH
+ ./example/ascii/example_ascii_to_lower
hello!
+ ./example/ascii/example_ascii_to_sentence
Hello!
'Enquoted'
1st
+ ./example/ascii/example_ascii_to_title
Hello There!
'Enquoted'
1st
+ ./example/ascii/example_ascii_to_upper
HELLO!

GFortran Output:

+ ./example/ascii/example_ascii_reverse
!dlroW ,olleH
+ ./example/ascii/example_ascii_to_lower
hello!
+ ./example/ascii/example_ascii_to_sentence
 Hello!
 'Enquoted'
 1st
+ ./example/ascii/example_ascii_to_title
 Hello There!
 'Enquoted'
 1st
+ ./example/ascii/example_ascii_to_upper
HELLO!

Shaikh-Ubaid
Shaikh-Ubaid commented Jan 12, 2024
View reviewed changes
.github/workflows/CI.yml
@@ -667,11 +667,16 @@ jobs:
run: |
git clone https://github.com/czgdp1807/stdlib.git
cd stdlib
git checkout lf15
git checkout 9ba07f7b42edebb33e82e6e94516bf423b9b8784
git checkout lf16
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lf16 is checked out from lf15.

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as ready for review January 12, 2024 16:32
certik
certik approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, that looks great. Several workarounds removed.

@certik certik merged commit 85bb857 into lfortran:main Jan 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shaikh-Ubaid @certik