Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update Windows build instructions #3101

Merged
merged 2 commits into from
Jan 14, 2024
Merged

doc: Update Windows build instructions #3101

merged 2 commits into from
Jan 14, 2024

Conversation

inkydragon
Copy link
Contributor

@inkydragon inkydragon commented Jan 13, 2024

I tried to build lfortran in WSL2 and for the most part it went well.
There are a few places in the documentation that need to be updated.

  • In addition to zlib, you need zstd, otherwise cmake will complain that it can't find the dependencies.
    Maybe this could be added to conda's environment configuration as well? Just like:

    - zstd-static=1.5.5

  • lfortran now generates an executable with the same name as the source file

  • Do we need to add -DWITH_RUNTIME_STACKTRACE=yes to the default cmake flags?
    Otherwise ./run_tests.py will throw an error when executing runtime_stacktrace_01.f90 * run_dbg
    Or skip the related tests if the WITH_RUNTIME_STACKTRACE flag is not set

    cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_LLVM=yes -DCMAKE_INSTALL_PREFIX=`pwd`/inst .\

@inkydragon
Copy link
Contributor Author

Random Thoughts: If only the documentation was changed, it might be possible to skip all code-related CIs.

on:
  push:
    paths-ignore:
      - 'doc/**'

paths-ignore

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good.

@certik certik merged commit b97ca0a into lfortran:main Jan 14, 2024
21 checks passed
@inkydragon inkydragon deleted the doc branch January 15, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants