Refactor code #3126
Merged
Refactor code #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaikh-Ubaid
force-pushed
the
refactor
branch
from
2ac603c
to
08499c6
Compare
certik
reviewed
Jan 16, 2024
src/bin/lfortran.cpp
Outdated
| _parse_linker_args(linker_flags_args, linker_flags); | ||
| _get_rpath_from_linker_flags(linker_flags, compiler_options); | ||
| } | ||
| int mainApp(int argc, char *argv[]) { |
There was a problem hiding this comment.
Suggested change
| int mainApp(int argc, char *argv[]) { | |
| int main_app(int argc, char *argv[]) { |
certik
reviewed
Jan 16, 2024
src/bin/lfortran.cpp
Outdated
| LCompilers::print_stack_on_segfault(); | ||
| #endif | ||
| try { | ||
| return mainApp(argc, argv); |
There was a problem hiding this comment.
Suggested change
| return mainApp(argc, argv); | |
| return main_app(argc, argv); |
certik
approved these changes
Jan 16, 2024
Shaikh-Ubaid
force-pushed
the
refactor
branch
from
08499c6
to
3f7a6f1
Compare
certik
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.