Importing issues with requirements and templates #3147
Conversation
ansharlubis
changed the title
src/libasr/modfile.cpp
Outdated
| @@ -7,6 +7,7 @@ | |||
| #include <libasr/serialization.h> | |||
| #include <libasr/bwriter.h> | |||
|
|
|||
| #include <libasr/pickle.h> | |||
There was a problem hiding this comment.
This might not be needed here.
|
Some of the new reference tests are 14K of lines, which will increase the size of the git repository. Do we need to check all that? Or can we just run it via integration tests. |
|
Does it make sense to keep the original all-in-one-file test (to ensure that still works), as well as the new split tests? |
|
Other than that, the changes look good to me. |
|
@certik Some of the tests are superfluous, I want to combine them first. For the matrix example, just the combined one should be enough. Integration test for the split files should be enough. However, I don't know how to add split files into the integration tests. |
|
Look at the modules_15 test, that contains several files as well. You probably need to add a main program, so that it creates an executable that can be run. |
|
I follow the other example, added the extra files into |
|
We have to debug it. |
| @@ -564,6 +564,51 @@ static inline std::string type_to_str(const ASR::ttype_t *t) | |||
| } | |||
| } | |||
|
|
|||
| static inline std::string type_to_str_with_substitution(const ASR::ttype_t *t, | |||
There was a problem hiding this comment.
Can you document what exactly this function does and how it differs to the other similar function for type comparison?
There was a problem hiding this comment.
Got it! I'll add the documentation in a separate pull request.
Addressing issues #3139 and #3138.
The following files make up the matrix example in separate modules: