-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added error message #3167
Added error message #3167
Conversation
@HarshitaKalani Please review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please add a test for this.
src/lfortran/parser/semantics.h
Outdated
@@ -1677,11 +1677,14 @@ void add_ws_warning(const Location &loc, | |||
"Use integer(4) instead of integer*4", | |||
{loc}, | |||
"help: write this as 'integer(4)'"); | |||
} else{ | |||
} else if(a_kind == 8){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} else if(a_kind == 8){ | |
} else if (a_kind == 8) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rectify it in the above case too?
You need to add the test here: tests/errors/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, thanks!
Fix #3071