Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lfortran: compile capital F files as well #3192

Merged
merged 2 commits into from
Jan 25, 2024
Merged

lfortran: compile capital F files as well #3192

merged 2 commits into from
Jan 25, 2024

Conversation

junghans
Copy link
Contributor

Fix #3189

certik
certik approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this!

@certik certik merged commit dabf403 into lfortran:main Jan 25, 2024
21 checks passed
@junghans junghans deleted the capitalF branch January 25, 2024 13:58
@junghans junghans mentioned this pull request Jan 25, 2024
Closed
@junghans
Copy link
Contributor Author

On a second thought, we maybe should preprocess the files with capital F automatically.

@certik
Copy link
Contributor

certik commented Jan 26, 2024

Maybe we should, other compilers do that as well. On the other hand I was hoping to treat all file extensions uniformly.

@junghans junghans mentioned this pull request Jan 26, 2024
Closed
This was referenced Feb 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined reference to `_gfortran_set_options'
2 participants
@junghans @certik