Implemented Idint #3193
Merged
Implemented Idint #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Addresed #3177 (comment), rest all looks good to me. Thanks!
Closed
certik
reviewed
Jan 25, 2024
| @@ -0,0 +1,11 @@ | |||
| program intrinsics_128 | |||
| double precision :: x | |||
| x = 4.23 | |||
There was a problem hiding this comment.
You have to write this as:
4.23d0
otherwise it's a single precision number, not double precision.
There was a problem hiding this comment.
Ahh okay, yes. I thought of this, but then LFortran casts it in ASR, hence I enabled auto-merge. I am sorry for it, will take care from next time.
There was a problem hiding this comment.
Yes, it gets cast, but as a Fortran programmer, if you want to get 4.230000000000000 and not 4.23000000134583745, you need to use d0 or _dp.
There was a problem hiding this comment.
Okay, yes. I will take care :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3177