Fix print related bugs #3224
Merged
Fix print related bugs #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
reviewed
Jan 26, 2024
| ASR::expr_t *empty_string = ASRUtils::EXPR(ASR::make_StringConstant_t( | ||
| al, loc, s2c(al, ""), str_type_len_0)); | ||
| a_values_vec.push_back(al, empty_string); | ||
| ASR::asr_t* file_write_asr_t = construct_leading_space(false, loc); |
There was a problem hiding this comment.
The leading space should only be inserted if compiler_options.print_leading_space.
There was a problem hiding this comment.
Yes, at the above location, it is inserted when format string is not specified and --print-leading-space is provided. Do you want to update this to any other logic?
There was a problem hiding this comment.
Ah, I missed the compiler_options.print_leading_space.
certik
approved these changes
Jan 26, 2024
Define and use construct_leading_space()
Shaikh-Ubaid
force-pushed
the
fix_print
branch
from
b3cedd6
to
34caf23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3215