New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: remove old compile time implementations #3246
Conversation
445f2e8
to
49c9128
Compare
@HarshitaKalani I think you also need to remove their implementations (if any) from the pure runtime library. |
Oh okay, will do that. Thanks! |
If you plan to do it in a separate PR, I think that is also fine. Maybe create an issue about it so we do not forget. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is good to merge as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge. Amazing work! Thanks for this. Also see #3246 (comment).
Towards: #3169