Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in adjustl() #3615

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Fix bug in adjustl() #3615

merged 5 commits into from
Mar 11, 2024

Conversation

Shaikh-Ubaid
Copy link
Member

fixes #3613

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as ready for review March 9, 2024 23:25
@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as draft March 9, 2024 23:55
@Shaikh-Ubaid
Copy link
Member Author

Working on this. Please do not merge.

@certik
Copy link
Contributor

certik commented Mar 10, 2024

You can merge it once it is ready.

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as ready for review March 11, 2024 08:38
@Shaikh-Ubaid Shaikh-Ubaid merged commit dec87fa into lfortran:main Mar 11, 2024
21 checks passed
@Shaikh-Ubaid Shaikh-Ubaid deleted the fix_adjustl branch March 11, 2024 08:53
Comment on lines -3012 to +3019
do while (i <= len(s) .and. isspace(s(i:i)))
i = i + 1
do while (i <= len(s))
if (isspace(s(i:i))) then
i = i + 1
else
exit
end if
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortran does not support short-circuiting. Hence the above logic was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stdlib: Bug in adjustl() intrinsic registry func
2 participants