Implement verify #3621
Merged
Implement verify #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshitaKalani
commented
Mar 11, 2024
certik
reviewed
Mar 11, 2024
Closed
HarshitaKalani
force-pushed
the
verify_02
branch
from
20b937c
to
266dce9
Compare
certik
reviewed
Mar 14, 2024
| @@ -534,6 +537,8 @@ namespace IntrinsicElementalFunctionRegistry { | |||
| "rrspacing"}, | |||
| {static_cast<int64_t>(IntrinsicElementalFunctions::Repeat), | |||
| "Repeat"}, | |||
| {static_cast<int64_t>(IntrinsicElementalFunctions::StringContainsSet), | |||
| "Verify"}, | |||
There was a problem hiding this comment.
Suggested change
| "Verify"}, | |
| "StringContainsSet"}, |
There was a problem hiding this comment.
If this is too complicated right now, just leave it and we can fix it in a separate PR.
certik
reviewed
Mar 14, 2024
| @@ -721,6 +726,7 @@ namespace IntrinsicElementalFunctionRegistry { | |||
| {"digits", {&Digits::create_Digits, &Digits::eval_Digits}}, | |||
| {"rrspacing", {&Rrspacing::create_Rrspacing, &Rrspacing::eval_Rrspacing}}, | |||
| {"repeat", {&Repeat::create_Repeat, &Repeat::eval_Repeat}}, | |||
| {"verify", {&StringContainsSet::create_StringContainsSet, &StringContainsSet::eval_StringContainsSet}}, | |||
There was a problem hiding this comment.
Suggested change
| {"verify", {&StringContainsSet::create_StringContainsSet, &StringContainsSet::eval_StringContainsSet}}, | |
| {"string_contains_set", {&StringContainsSet::create_StringContainsSet, &StringContainsSet::eval_StringContainsSet}}, |
certik
reviewed
Mar 14, 2024
HarshitaKalani
force-pushed
the
verify_02
branch
from
266dce9
to
b413823
Compare
|
Fails due to: #3584 |
certik
approved these changes
Mar 16, 2024
There was a problem hiding this comment.
I think that this is good to merge, thanks @HarshitaKalani !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #3497