Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed compare macros from asr builder #3657

Merged
merged 3 commits into from
Mar 17, 2024
Merged

removed compare macros from asr builder #3657

merged 3 commits into from
Mar 17, 2024

Conversation

parth121101
Copy link
Contributor

fixes: #3644

@parth121101 parth121101 mentioned this pull request Mar 17, 2024
Closed
@parth121101 parth121101 marked this pull request as ready for review March 17, 2024 05:53
@certik certik requested a review from Pranavchiku March 17, 2024 05:58
@Pranavchiku
Copy link
Contributor

I'll review this in a while

@Pranavchiku Pranavchiku added the enhancement Issues or pull request for enhancing existing functionality label Mar 17, 2024
Pranavchiku
Pranavchiku requested changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change requested, once done this will be good to merge.

@Pranavchiku Pranavchiku marked this pull request as draft March 17, 2024 06:57
@Pranavchiku Pranavchiku added refactor Issue or pull request to refactor existing code and removed enhancement Issues or pull request for enhancing existing functionality labels Mar 17, 2024
Pranavchiku
Pranavchiku approved these changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @parth121101 !

@Pranavchiku Pranavchiku marked this pull request as ready for review March 17, 2024 08:16
@Pranavchiku
Copy link
Contributor

When you rebase there should be no commit like 0ecec60

@Pranavchiku Pranavchiku merged commit a4b64e1 into lfortran:main Mar 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
refactor Issue or pull request to refactor existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove compare macro from ASRBuilder
2 participants
@parth121101 @Pranavchiku