Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement lgt, llt, lle,lge #3659

Merged
merged 8 commits into from
Mar 18, 2024
Merged

Conversation

HarshitaKalani
Copy link
Contributor

@HarshitaKalani HarshitaKalani commented Mar 17, 2024

Continuing: #3570
Towards: #3034

@HarshitaKalani
Copy link
Contributor Author

HarshitaKalani commented Mar 17, 2024

program main
    character(5), allocatable :: a, b
    print*, lgt(maybe(a), b)

    contains
    function maybe(string) result(maybe_string)
        character(5), allocatable:: string
        character(len=len(string)) :: maybe_string
        maybe_string = 'works'
    end function maybe

end
$ lfortran a.f90
Segmentation fault (core dumped)

This does not work yet.

@HarshitaKalani HarshitaKalani added the intrinsic Issue or pull request specific to intrinsic function label Mar 17, 2024
@HarshitaKalani HarshitaKalani marked this pull request as ready for review March 17, 2024 12:04
@Pranavchiku Pranavchiku changed the title Implement lgt, llt, lle, lge feat: implement lgt, llt, lle,lge Mar 17, 2024
@Pranavchiku Pranavchiku added the feature Issue or pull request for adding a new feature label Mar 17, 2024
Copy link
Contributor

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion requested, also this PR needs to be rebased and conflicts resolved.

@Pranavchiku Pranavchiku marked this pull request as draft March 17, 2024 15:14
@Pranavchiku
Copy link
Contributor

The failure seems unrelated and can be fixed by rerun

100% tests passed, 0 tests failed out of 3

Total Test time (real) =   9.93 sec
+ cd ..
+ git clean -dfx
Removing lf-fast/
Removing lf/
Removing model.dat
+ git checkout -t origin/namelist
fatal: 'origin/namelist' is not a commit and a branch 'namelist' cannot be created from it

@certik
Copy link
Contributor

certik commented Mar 18, 2024

The failure is due to #3663.

@certik certik marked this pull request as ready for review March 18, 2024 13:56
@certik certik merged commit 62a01e9 into lfortran:main Mar 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issue or pull request for adding a new feature intrinsic Issue or pull request specific to intrinsic function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants