Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement scan #3660

Merged
merged 10 commits into from
Mar 18, 2024
Merged

Implement scan #3660

merged 10 commits into from
Mar 18, 2024

Conversation

HarshitaKalani
Copy link
Contributor

@HarshitaKalani HarshitaKalani commented Mar 17, 2024 •
edited

Towards: #3034

@HarshitaKalani HarshitaKalani added the intrinsic Issue or pull request specific to intrinsic function label Mar 17, 2024
@HarshitaKalani HarshitaKalani marked this pull request as ready for review March 17, 2024 14:19
Shaikh-Ubaid
Shaikh-Ubaid reviewed Mar 17, 2024
View reviewed changes
Copy link
Member

@Shaikh-Ubaid Shaikh-Ubaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared two comments. Rest looks good to me. Thanks for this. Great work!

integration_tests/intrinsics_189.f90 Outdated Show resolved Hide resolved
src/lfortran/semantics/ast_common_visitor.h Show resolved Hide resolved
@Shaikh-Ubaid
Copy link
Member

Please mark as "Ready for review" when ready.

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as draft March 17, 2024 18:44
@Pranavchiku
Copy link
Contributor

Same error, seems unrelated:

+ cd ..
+ git clean -dfx
Removing lf-fast/
Removing lf/
Removing model.dat
+ git checkout -t origin/namelist
fatal: 'origin/namelist' is not a commit and a branch 'namelist' cannot be created from it

@certik
Copy link
Contributor

certik commented Mar 18, 2024

The failure is due to #3663.

@HarshitaKalani HarshitaKalani marked this pull request as ready for review March 18, 2024 17:49
@certik certik enabled auto-merge March 18, 2024 18:01
@certik certik merged commit b1883d8 into lfortran:main Mar 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaikh-Ubaid Shaikh-Ubaid Shaikh-Ubaid left review comments

@certik certik certik approved these changes

Assignees
No one assigned
Labels
intrinsic Issue or pull request specific to intrinsic function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HarshitaKalani @Shaikh-Ubaid @Pranavchiku @certik