Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stacktrace.cpp: add limits.h for PATH_MAX #3704

Merged
merged 1 commit into from
Mar 25, 2024
Merged

stacktrace.cpp: add limits.h for PATH_MAX #3704

merged 1 commit into from
Mar 25, 2024

Conversation

barracuda156
Copy link
Contributor

@barracuda156 barracuda156 commented Mar 25, 2024 •
edited

@certik I only got the error when enabled MACH_O, not otherwise. Therefore hiding it inside that macro.

@certik
Copy link
Contributor

certik commented Mar 25, 2024 •
edited

The CI error seems unrelated: #3707. I am rerunning the failed job.

certik
certik approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, thanks!

@certik certik merged commit 5b2c832 into lfortran:main Mar 25, 2024
21 checks passed
@barracuda156 barracuda156 deleted the path_max branch March 26, 2024 00:10
@barracuda156
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barracuda156 @certik