pass "nopass" for class procedure having nopass and handle optional arguments for ClassProcedure with/without nopass

[gxyd]

pass "nopass" presence along to be used by CallBody

I've written the (only) test case with just --show-asr, as the --show-llvm will still raise an error because of a problem in transform_optional_argument_function pass (for details, see: #3632)

[Pranavchiku]

Can you try updating test references and see if CI passes.

[Pranavchiku]

Looks good, let's get CI working, dropped comments to improve test.

[gxyd]

Can you try updating test references and see if CI passes.

I think it was a failure similar to the one mentioned in this issue: #3707. I've pushed a commit, hopefully the tests pass now.

[gxyd]

If you do like the changes, and accept it, I would request for it to be a squash the commits when merging.

[Pranavchiku]

I am just not sure of these nopass stuff, so I'll prefer to wait for one more approval before merging :)
Thanks for your work!

[gxyd]

I am just not sure of these nopass stuff, so I'll prefer to wait for one more approval before merging :)

Sounds good.

[gxyd]

It's now tested with GFortran.

[gxyd]

@certik , this is now ready for a review. I've made more changes after your last review. We should now be able to compile the test case completely (not just till ASR), and it's tested as well (I've used llvm2 label for it).

The issue #3632 still remains relevant (when nopass isn't passed to the class procedure), which depends on the changes introduced in this MR. Let me know what you think.

Update: The issue #3632 is also now handled in this PR.

[gxyd]

This PR now also fixes #3632

[gxyd]

@certik , could you help me understand why the two CI checks are failing?

[Pranavchiku]

CI failure:

[ 19%] Building Fortran object CMakeFiles/print_03_FAST.dir/print_03.f90.o
[ 23%] Building Fortran object CMakeFiles/print_05_FAST.dir/print_05.f90.o
make[2]: *** [CMakeFiles/module_function_with_nopass_FAST.dir/module_function_with_nopass.f90.o] Segmentation fault: 11
[ 26%] Linking Fortran executable error_stop_02_FAST
make[1]: *** [CMakeFiles/module_function_with_nopass_FAST.dir/all] Error 2
[ 30%] Linking Fortran executable error_stop_01_FAST
make[1]: *** Waiting for unfinished jobs....
[ 34%] Linking Fortran executable print_01_FAST
[ 38%] Linking Fortran executable stop_01_FAST
[ 42%] Linking Fortran executable print_03_FAST
make: *** [all] Error 2

[gxyd]

Ah, I see. I did see the error ofcourse, but I didn't know that you can simply run that locally by lfortran integration_tests/module_function_with_nopass.f90 --fast, i.e. by adding --fast in the command. I don't much about --fast, I only see: (Best performance (disable strict standard compliance), which doesn't make it much clear for me honestly.

[certik]

Related #3733.

[certik]

The CI failure seems unrelated: #3736.

[gxyd]

Yes, something along the lines of #3619

[gxyd]

Can we squash the commits when merging? (If you also think that makes more sense)

[gxyd]

As otherwise, they would introduce un-necessary reference files in our commit history.

[certik]

Tests pass on a rerun. I rebased and auto-squash-merged.

fixed