test: strengthen tests for bessely0 function
#3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
reviewed
Mar 26, 2024
Pranavchiku
requested changes
Mar 26, 2024
Pranavchiku
changed the title
bessely0 function
Pranavchiku
added
tests
intrinsic
Pranavchiku
changed the title
bessely0 functionbessely0 function
Done @Pranavchiku, thanks for letting me know a better way to manage this tests |
|
Would you mind adding test for large positive values? |
I will add them @Pranavchiku |
Pranavchiku
added
the
needs rebase
parth121101
force-pushed
the
testsBessely0
branch
from
15a8b60
to
9e316c9
Compare
Pranavchiku
removed
the
needs rebase
Pranavchiku
reviewed
Mar 27, 2024
Pranavchiku
reviewed
Mar 27, 2024
Comment on lines
+21
to
+23
| expected = [ 7.9836428649154907E-155_dp,-7.0751499885966513E-155_dp, 4.4632457212022053E-155_dp, -7.7717941781117305E-156_dp, & | ||
| -2.1476418943648812E-002_dp, 0.45752410314844527_dp, -3.6134118144921369E-003_dp, -1.1810118244863275_dp, & | ||
| 5.7258225070763252E-002_dp, -1.9980991452871046E-002_dp, 0.27136794388300378_dp, 0.26703177612919299_dp, & |
Pranavchiku
approved these changes
Mar 27, 2024
certik
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @Pranavchiku I have added more tests for bessel_y0 function for rigorous testing.