Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old runtime code in lfortran_intrinsic_optimization file #3717

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Remove old runtime code in lfortran_intrinsic_optimization file #3717

merged 2 commits into from
Mar 28, 2024

Conversation

HarshitaKalani
Copy link
Contributor

No description provided.

@HarshitaKalani HarshitaKalani added the intrinsic Issue or pull request specific to intrinsic function label Mar 27, 2024
@HarshitaKalani HarshitaKalani marked this pull request as ready for review March 28, 2024 03:46
Pranavchiku
Pranavchiku reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why we had this file, I will wait for an approval before merging this.

@Pranavchiku Pranavchiku added the refactor Issue or pull request to refactor existing code label Mar 28, 2024
@Shaikh-Ubaid
Copy link
Member

I am not sure why we had this file, I will wait for an approval before merging this.

I think these are now implemented via the intrinsic registry functions. Hence, it is safe to remove them.

Shaikh-Ubaid
Shaikh-Ubaid approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@Shaikh-Ubaid Shaikh-Ubaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Thanks for this! Good catch and Great work!

@Shaikh-Ubaid
Copy link
Member

I am squash merging this.

@Shaikh-Ubaid Shaikh-Ubaid merged commit 3e01f2f into lfortran:main Mar 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku left review comments

@Shaikh-Ubaid Shaikh-Ubaid Shaikh-Ubaid approved these changes

Assignees
No one assigned
Labels
intrinsic Issue or pull request specific to intrinsic function refactor Issue or pull request to refactor existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HarshitaKalani @Shaikh-Ubaid @Pranavchiku