Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use inbuilt math function for bessel_xx instead #3737

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

Pranavchiku
Copy link
Contributor

One may refer https://pubs.opengroup.org/onlinepubs/7908799/xsh/math.h.html for more math functions. Sorry for adding more to technical debt without prior research and causing trouble in LICENSE.

@Pranavchiku Pranavchiku added intrinsic Issue or pull request specific to intrinsic function refactor Issue or pull request to refactor existing code labels Mar 28, 2024
@Pranavchiku Pranavchiku marked this pull request as ready for review March 28, 2024 18:36
@Pranavchiku
Copy link
Contributor Author

cc @parth121101 @HarshitaKalani

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Yes, let's use math.h functions whenever possible.

We'll add our own implementation later.

@Pranavchiku Pranavchiku merged commit 968182b into lfortran:main Mar 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intrinsic Issue or pull request specific to intrinsic function refactor Issue or pull request to refactor existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants