Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: broadcasting for user-defined elemental subroutines #3767

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

gxyd
Copy link
Contributor

@gxyd gxyd commented Apr 2, 2024

Fixes #3730

@gxyd gxyd changed the title Elem subroutine broadcasting enh: broadcasting for user-defined elemental subroutines Apr 2, 2024
@gxyd gxyd mentioned this pull request Apr 2, 2024
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this looks good. If we discover any corner cases, we can fix them later. This gets the basic elemental subroutines working.

Thank you!

@certik certik merged commit 2788ddd into lfortran:main Apr 2, 2024
21 checks passed
@gxyd gxyd deleted the elem_subroutine_broadcasting branch April 3, 2024 05:59
gxyd added a commit to gxyd/lfortran that referenced this pull request Apr 13, 2024
we shouldn't have disallowed non-external user subroutine's call to
be converted to do-loop, it was a mistake made in lfortran#3767

Also delete the replicate of the test-file mistakenly git-commited
gxyd added a commit to gxyd/lfortran that referenced this pull request Apr 13, 2024
we shouldn't have disallowed broadcasting for non-external user subroutine call's
it was a mistake made in lfortran#3767

Also delete the replica of the test-file mistakenly git-commited
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elemental subroutines are not broadcasted correctly
2 participants