Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement acosd intrinsic function #3804

Merged
merged 6 commits into from
Apr 9, 2024
Merged

feat: implement acosd intrinsic function #3804

merged 6 commits into from
Apr 9, 2024

Conversation

parth121101
Copy link
Contributor

No description provided.

Pranavchiku
Pranavchiku requested changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment to be addressed before this PR becomes ready to merge. Thank you!

integration_tests/intrinsics_205.f90 Show resolved Hide resolved
src/libasr/pass/intrinsic_functions.h Outdated Show resolved Hide resolved
@Pranavchiku Pranavchiku added intrinsic Issue or pull request specific to intrinsic function feature Issue or pull request for adding a new feature labels Apr 7, 2024
Pranavchiku
Pranavchiku requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments above, everything but test looks good.

@parth121101 parth121101 marked this pull request as ready for review April 8, 2024 14:40
@parth121101
Copy link
Contributor Author

@Pranavchiku I applied one of your suggestions. It was about the utilization of M_PI from math.h library. I checked its value and found that it was less accurate. Its value was 3.14159. Previously, I was using the value of PI as 3.14159265358979323846. So what do you think which one should I use?

Pranavchiku
Pranavchiku requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing compile time tests, left comments above.

@Pranavchiku Pranavchiku marked this pull request as draft April 9, 2024 11:32
@parth121101 parth121101 marked this pull request as ready for review April 9, 2024 14:04
@certik certik requested a review from Pranavchiku April 9, 2024 15:51
@Pranavchiku Pranavchiku enabled auto-merge (squash) April 9, 2024 17:43
@Pranavchiku
Copy link
Contributor

I am sorry I resolved conflicts via github UI which resulted into Merge commit and hence will have to squash and merge this PR, I hope this is fine.

auto-merge was automatically disabled April 9, 2024 18:04

Head branch was pushed to by a user without write access

Pranavchiku
Pranavchiku approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, thanks!

@Pranavchiku Pranavchiku merged commit 038f8e8 into lfortran:main Apr 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik left review comments

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
feature Issue or pull request for adding a new feature intrinsic Issue or pull request specific to intrinsic function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@parth121101 @Pranavchiku @certik