fix: assign "m_end" as UpperBound for an array of character #3835
Conversation
gxyd
changed the title
|
Does the test in this PR fail in master? If so, then just adding the test I think is fine. The problem with the ASR test is that it doesn't check that The ASR tests were instrumental to bootstrap the compiler, since we couldn't compile many of the features. But now in the late stages of the compiler, the ASR tests are not as useful. |
| @@ -1376,6 +1376,7 @@ RUN(NAME character_01 LABELS gfortran llvm) | |||
| RUN(NAME character_02 LABELS gfortran llvm) | |||
| RUN(NAME character_03 LABELS gfortran llvm) | |||
| RUN(NAME character_04 LABELS gfortran llvm) | |||
| RUN(NAME char_array_01 LABELS gfortran llvm) | |||
There was a problem hiding this comment.
I actually made it a part of integration tests and also saved it's ASR as well, see: https://github.com/lfortran/lfortran/pull/3835/files#diff-1ab5e0955089e3094bab05294193ebb1d6f463e1739a7d0b0db2d3297f5a99c8R3881-R3883.
The ASR tests were instrumental to bootstrap the compiler, since we couldn't compile many of the features. But now in the late stages of the compiler, the ASR tests are not as useful.
I still personally would've liked to keep the ASR test, but I think you know things better, so I'm going to follow that 😃
It does. |
| char_arr2(:) = " " | ||
|
|
||
| print *, char_arr1 | ||
| print *, char_arr2 |
There was a problem hiding this comment.
Let's test actual values using if(....) error stop conditions.
|
We've two test files now:
|
Fixes #3039