enh: add intrinsics with double precision input/output #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshitaKalani
added
the
intrinsic
|
This method makes the intrinsics with double precision input/output work but does not throw error if the arguments provided are not double precision. |
Pranavchiku
reviewed
Apr 10, 2024
Pranavchiku
reviewed
Apr 10, 2024
| {"dexp", "exp"}, | ||
|
|
||
| {"dmin1", "min"}, | ||
| {"dmax1", "max"}, | ||
|
|
||
| {"dacos", "acos"}, |
There was a problem hiding this comment.
Following comment you left, do these function only accept double precision input? If yes, let's open an issue and add
error not reported
There was a problem hiding this comment.
I believe this was intended to make the intrinsics with specific type double precision input/output. However, this works well for intrinsics with input/output as integer like iabs. Will create an issue explaining the same.
Pranavchiku
reviewed
Apr 10, 2024
Pranavchiku
changed the title
HarshitaKalani
force-pushed
the
double_precision_01
branch
from
403d359
to
29c2164
Compare
Pranavchiku
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: #492