Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement bit_size and remove old unwanted code from lfortran_intrinsic_builtin.f90 file #3848

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

HarshitaKalani
Copy link
Contributor

@HarshitaKalani HarshitaKalani commented Apr 10, 2024

Towards: #492
Towards: #3034


print*, bit_size(j)
if( bit_size(j) /= 64 ) error stop

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also test MIN_NEGATIVE_INTEGER, -1e-15, 0, 1e-15, MAX_POS_INTEGER

Copy link
Contributor

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, suggested change can be done in subsequent PRs.

@Pranavchiku Pranavchiku changed the title Implement bit_size and remove old unwanted code from lfortran_intrinsic_builtin.f90 file feat: implement bit_size and remove old unwanted code from lfortran_intrinsic_builtin.f90 file Apr 11, 2024
@Pranavchiku Pranavchiku added intrinsic Issue or pull request specific to intrinsic function refactor Issue or pull request to refactor existing code labels Apr 11, 2024
@Pranavchiku
Copy link
Contributor

I'll request you to rebase it on top of main and enable auto merge.

@Pranavchiku Pranavchiku added the needs rebase Rebase on top of latest main is required/desired label Apr 11, 2024
@HarshitaKalani HarshitaKalani merged commit 465f913 into lfortran:main Apr 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intrinsic Issue or pull request specific to intrinsic function needs rebase Rebase on top of latest main is required/desired refactor Issue or pull request to refactor existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants