Refactor: Throw error if specific type intrinsics are called with wrong type arguments #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshitaKalani
force-pushed
the
specific_type_01
branch
2 times, most recently
from
dc3e334
to
a9e8a39
Compare
|
Is this ready for review? |
|
Yes, it can be reviewed. I wanted some suggestions if this approach looks fine to you. I was trying to make it modular. |
certik
approved these changes
Apr 12, 2024
HarshitaKalani
force-pushed
the
specific_type_01
branch
from
a9e8a39
to
4a5976e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3849