Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement intrinsic nearest #4018

Merged
merged 3 commits into from
May 18, 2024
Merged

Conversation

HarshitaKalani
Copy link
Contributor

Towards: #4017 , #492

@HarshitaKalani HarshitaKalani added the intrinsic Issue or pull request specific to intrinsic function label May 17, 2024
result = ?
end function
*/
// YET TO BE IMPLEMENTED
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about how to go about the runtime implementation of it. Wish to first discuss and then proceed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to create a (to be implemented) RealNearest ASR node here: #4024.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just give a compiler exception here ("not implemented")

@HarshitaKalani HarshitaKalani marked this pull request as ready for review May 17, 2024 08:44
@HarshitaKalani HarshitaKalani mentioned this pull request May 17, 2024
54 tasks
@HarshitaKalani HarshitaKalani force-pushed the nearest_01 branch 2 times, most recently from 390eb9d to 302bbc6 Compare May 18, 2024 03:35
@HarshitaKalani HarshitaKalani merged commit e1c9dab into lfortran:main May 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intrinsic Issue or pull request specific to intrinsic function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants