[parser] enh: allow whitespace in Format specification #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blank characters may precede the initial left parenthesis of the format specification and additional blank characters may appear at any point within the format specification, with no effect on the interpretation of the format specification. e.g.; `(I 1 2)` is same as `(I12)` for format specification and are both valid. Earlier, we used to raise tokenizer error because of no support for it issue was initially raised in lfortran#4040
gxyd
commented
May 22, 2024
|
Surprising that test fails on ubuntu but passes on mac and windows |
certik
reviewed
May 22, 2024
|
The failure is: |
gxyd
commented
May 22, 2024
|
I think the current failure of CI isn't related to this PR. |
|
The failure is due to #3985. |
certik
approved these changes
May 23, 2024
I'll give that a look sometime I think. |
|
I think it's fine. Not as verbose as before. I can't think right now of any way to simplify, so let's go with this. Let's restore the original test and then we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blank characters may precede the initial left parenthesis of the format specification and additional blank characters may appear at any point within the format specification, with no effect on the interpretation of the format specification.
e.g.;
(I 1 2)is same as(I12)for format specification and are both valid.Earlier, we used to raise tokenizer error because of no support for it
issue was initially raised in #4040