Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM: Support defining functions in any order #635

Merged
merged 11 commits into from
Aug 19, 2022
Merged

WASM: Support defining functions in any order #635

merged 11 commits into from
Aug 19, 2022

Conversation

Shaikh-Ubaid
Copy link
Member

This PR adds support for defining functions in any order in the wasm backend.

@Shaikh-Ubaid Shaikh-Ubaid added the wasm WebAssembly Backend label Aug 19, 2022
@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as draft August 19, 2022 15:52
@Shaikh-Ubaid
Copy link
Member Author

I am adding an integration_test for this.

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as ready for review August 19, 2022 16:04
@Shaikh-Ubaid
Copy link
Member Author

This is ready. Please possibly review and please share feedback.

certik
certik approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for fixing it!

@Shaikh-Ubaid Shaikh-Ubaid merged commit 5fc1027 into lfortran:main Aug 19, 2022
@Shaikh-Ubaid Shaikh-Ubaid deleted the wasm_support_funcs_in_any_order branch August 19, 2022 16:43
@Shaikh-Ubaid Shaikh-Ubaid mentioned this pull request Aug 22, 2022
Closed
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
wasm WebAssembly Backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shaikh-Ubaid @certik