Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] XDG Base Directory Support #252

Closed
ghost opened this issue Nov 23, 2019 · 6 comments
Closed

[Feature Request] XDG Base Directory Support #252

ghost opened this issue Nov 23, 2019 · 6 comments

Comments

@ghost
Copy link

ghost commented Nov 23, 2019

calcurse stores its files by default in $HOME/.calcurse.

It should store config files in $XDG_CONFIG_HOME/calcurse and its data files in $XDG_DATA_HOME/calcurse instead.

Defaults if not set:

  • XDG_CONFIG_HOME: "$HOME/.config"
  • XDG_DATA_HOME: "$HOME/.local/share"

Current workaround:

$ calcurse -C "$XDG_CONFIG_HOME/calcurse" -D "$XDG_DATA_HOME/calcurse"

Alternatively, keep $HOME/.calcurse as default but if $HOME/.config/calcurse or $HOME/.local/share/calcurse exist then use those instead.

@lfos
Copy link
Owner

lfos commented Dec 11, 2019

I am not opposed to make calcurse look in $XDG_CONFIG_HOME and $XDG_DATA_HOME as alternative default config/data directories. Patches welcome!

@ghost
Copy link
Author

ghost commented Dec 13, 2019

@lfos Just to make sure, which solution are we going for? I would be happy to do this.

  1. Full XDG support: Use $XDG_CONFIG_HOME/calcurse and $XDG_DATA_HOME/calcurse as defaults and only use $HOME/.calcurse if it exists for backward compatibility.
  2. Partial XDG support: Keep using $HOME/.calcurse as default, but if $XDG_CONFIG_HOME/calcurse or $XDG_DATA_HOME/calcurse exist then use those instead.

@lfos
Copy link
Owner

lfos commented Dec 16, 2019

Full XDG support sounds fine. We need to make sure that we do not break any old setups that (need to) store their configs in ~/.calcurse/. Also, I think there is a lot of documentation to update with the new paths. If it's the new default, we want everything to refer to ~/.config/calcurse/ instead of ~/.calcurse/.

@ghost
Copy link
Author

ghost commented Dec 20, 2019

Added in #254.

@ghost ghost closed this as completed Dec 20, 2019
@ghost
Copy link

ghost commented Mar 3, 2020

Dang I've been waiting for this for so many years. Thanks so much @Nitroretro, if you have some way of donating I would like to send you some bucks.

@ghost
Copy link
Author

ghost commented Mar 5, 2020

@billop No need, maybe redirect it to lfos instead? https://calcurse.org/donate/

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant