Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurrent appointment issue #26

Closed
rgc69 opened this issue Feb 11, 2017 · 1 comment
Closed

Recurrent appointment issue #26

rgc69 opened this issue Feb 11, 2017 · 1 comment

Comments

@rgc69
Copy link

rgc69 commented Feb 11, 2017

Hi, sorry to bother you again, but there are issues with the recurrent appointments....
Version: calcurse 4.2.2-3-g2084
Let me try to explain. Yesterday all my (new, first time insert) appointments were notified as they have to: notify-bar countdown, notify-send bubble, all ok. Today, my first 7 recurrent appointments are missed (in the sense that there is no countdown for the first of them), and the notify-bar notify me only of the last one, this evening at 8:10pm. My notification.notifyall = unflagged-only , and all the appointments are unflagged, BUT, if I flag and then unflag the first one of this morning(the trick I show you last time), it appears in the notify-bar! I show you my data:
02/10/2017 @ 11:30 -> 02/10/2017 @ 12:30 {1D -> 06/15/2017} |Haskell
02/10/2017 @ 13:10 -> 02/10/2017 @ 14:00 {1D} |Lunch
02/10/2017 @ 15:30 -> 02/10/2017 @ 16:30 {1D -> 06/15/2017} |Test
02/10/2017 @ 16:35 -> 02/10/2017 @ 16:55 {1D} |Gymn
02/10/2017 @ 17:30 -> 02/10/2017 @ 18:30 {1D -> 06/15/2017} |Mathematica
02/10/2017 @ 18:35 -> 02/10/2017 @ 19:20 {1D -> 02/14/2017} |Blacklist
02/10/2017 @ 20:10 -> 02/10/2017 @ 20:55 {1D} |Dinner
02/11/2017 @ 09:30 -> 02/11/2017 @ 10:30 {1D -> 06/15/2017} |Test
I get notification countdown for Dinner, and not for the other ones. Lunch, for example, has the same structure, but it's not in the notify-bar. Even if I change it in Aunch (alphabetical order :) ), there is always Dinner. Thank you for your work, and let me know :)

lfos pushed a commit that referenced this issue Feb 11, 2017
In addition to checking whether a recurrent item predates the current
next appointment, we need to check that the actual occurrence of the
item predates the current appointment as well.

Fixes GitHub issue #26.

Signed-off-by: Lukas Fleischer <lfleischer@calcurse.org>
@lfos
Copy link
Owner

lfos commented Feb 11, 2017

There was another bug in the notification code for recurrent items. Should be fixed now!

@lfos lfos closed this as completed Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants