Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU: Add VendorID and DeviceID information under Windows #83

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

julianxhokaxhiu
Copy link
Contributor

Hello,

I managed to find some time and look at how the information is obtained in Windows. This is my proposal for the issue I've opened. Let me know what you think about it.

Also, the new example looks like this now after the patch:

----------------------------------- GPU -----------------------------------
GPU 0:
  vendor:           NVIDIA
  model:            NVIDIA GeForce RTX 3070 Laptop GPU
  driverVersion:    31.0.15.5186
  memory [MiB]:     4095
  frequency:        0
  cores:            0
  vendor_id:        10DE
  device_id:        249D
GPU 1:
  vendor:           Advanced Micro Devices, Inc.
  model:            AMD Radeon(TM) Graphics
  driverVersion:    31.0.21912.14
  memory [MiB]:     512
  frequency:        0
  cores:            0
  vendor_id:        1002
  device_id:        1638

Fixes #82

Copy link
Owner

@lfreist lfreist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution! I looked through it and it looks good so far. Only thing to claim is the failing style check:

Checking ./src/windows/gpu.cpp: FAILED!

Once you fixed that, I'll merge the PR. You can use clang-format to check the style.

Thank you!

@julianxhokaxhiu
Copy link
Contributor Author

Hello @lfreist thanks a lot for the nice feedback :)

Added one more commit to fix the format using clang-format. Hopefully I did the right thing.

Let me know, thanks!

@lfreist lfreist merged commit 9ba5dfe into lfreist:main Mar 28, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose GPU vendor_id and device_id on Windows
2 participants