Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve compiler warnings #87

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: resolve compiler warnings #87

wants to merge 2 commits into from

Conversation

jvsluis
Copy link

@jvsluis jvsluis commented Jun 18, 2024

Resolves two compiler warnings due to:

  • unused variable
  • comparing unsigned with signed int

Specifically:

  • warning: unused variable ‘i’ [-Wunused-variable]
  • warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]

@jvsluis
fix: cast unsigned to int to match signedness
84c5bad 
static cast unsigned int to an int before comparing with the index
variable which is an int. Failing to do so causes a compiler warning for
comparison of integer expressions with different signedness.
@jvsluis
fix: remove unused variable
eaaf7ed 
removes unused variable i in this scope to resolve compiler warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminya aminya aminya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jvsluis @aminya