Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grant cognito lambda execution for each trigger #88

Conversation

jeffreymlewis
Copy link

Grant cognito lambda execution permission for each defined trigger. This works around a known bug in the AWS provider.

hashicorp/terraform-provider-aws#8373

@jeffreymlewis jeffreymlewis changed the title Grant cognito lambda execution for each trigger feat: grant cognito lambda execution for each trigger Jul 11, 2022
@jeffreymlewis jeffreymlewis force-pushed the jeffreymlewis/feat/allow-cognito-to-execute-lambda-triggers branch from 38ca58b to 4ef2e1e Compare July 11, 2022 20:53
Grant cognito lambda execution permission for each defined trigger. This
is to work around a known bug in the AWS provider.
hashicorp/terraform-provider-aws#8373
@jeffreymlewis jeffreymlewis force-pushed the jeffreymlewis/feat/allow-cognito-to-execute-lambda-triggers branch from 4ef2e1e to 06c6284 Compare July 11, 2022 21:04
@lgallard
Copy link
Owner

@jeffreymlewis are you sure those lambda permission can't be granted outside the module? I'd rather use information from the module outputs to grant those permission to the lambda functions. What do you think?

@jeffreymlewis
Copy link
Author

jeffreymlewis commented Jul 14, 2022

@jeffreymlewis are you sure those lambda permission can't be granted outside the module? I'd rather use information from the module outputs to grant those permission to the lambda functions. What do you think?

Hi @lgallard thanks for the reply.

It's definitely possible to write a wrapper and add an aws_lambda_permission resource based on module output. However, given that literally everyone using Cognito lambda triggers will need to do this, I thought it would be good to add it here.

@lgallard
Copy link
Owner

@jeffreymlewis I'm closing this because I'd rather maintain resources and logic related to the module's functionality If there a need to include lambda resources we can revisit your changes. Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants