-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Promise polyfill #79
Comments
The main point of this library is that it Just Works™️ across as many browsers as possible, so I want IE to work out of the box. However, I'd be open to a PR with suitably designed way to opt out of shipping a separate polyfill fallback (note that the polyfill is not used in modern browsers as of #59, so the main remaining concern should be code bloat), e.g.
Examples of similar projects successfully supporting an optional polyfill like this would be useful to know. |
One example of a project that successfully asks people to use their own polyfill is React. From JavaScript Environment Requirements for React:
Seems fairly reasonable to have a BYOP (bring your own polyfill) stance if you need to support older browsers or are including your own polyfill already (ie. core-js) and don't need a duplicate. |
Obligatory status icon required: |
- The default build used by `node`/`npm` no longer includes a bundled `Promise` polyfill. #79 - The main benefit of this is that it reduces the build to ≈40% its previous size. - You can still use a version wiith the polyfill included. See `README.md` for instructions.
Instead of bringing in a Promise polyfill, this library should encourage users to bring their own if they need to support old browsers, but shouldn't make this assumption by itself.
In my case I do want that polyfill, but I'm already bringing my own, so this one would just unnecessarily increase my bundle size.
The text was updated successfully, but these errors were encountered: