Skip to content

Commit

Permalink
Fix declarations of centroided/smoothed setters for OnDiskMSnExp objects
Browse files Browse the repository at this point in the history
With current R-devel (R 4.4), trying to install MSnBase <= 2.25.2 fails
with error messages complaining about the declarations of the centroided<-
and smoothed<- methods for OnDiskMSnExp objects. The complain is:

  arguments ('value') after '...' in the generic must appear in
  the method, in the same place at the end of the argument list

This commit fixes the method delcarations so that they are compatible
with R >= 4.4.
  • Loading branch information
hpages committed Jun 24, 2023
1 parent 90707ae commit 525baaa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
@@ -1,6 +1,6 @@
Package: MSnbase
Title: Base Functions and Classes for Mass Spectrometry and Proteomics
Version: 2.25.2
Version: 2.25.3
Description: MSnbase provides infrastructure for manipulation,
processing and visualisation of mass spectrometry and
proteomics data, ranging from raw to quantitative and
Expand Down
4 changes: 2 additions & 2 deletions R/methods-OnDiskMSnExp.R
Expand Up @@ -184,7 +184,7 @@ setMethod("centroided", "OnDiskMSnExp",

setReplaceMethod("centroided",
signature(object = "OnDiskMSnExp", value = "logical"),
function(object, value, msLevel.) {
function(object, msLevel., ..., value) {
if (missing(msLevel.)) {
if (length(value) == 1)
value <- rep(value, length(object))
Expand Down Expand Up @@ -223,7 +223,7 @@ setMethod("smoothed", "OnDiskMSnExp",

setReplaceMethod("smoothed",
signature(object = "OnDiskMSnExp", value = "logical"),
function(object, value, msLevel.) {
function(object, msLevel., ..., value) {
if (missing(msLevel.)) {
if (length(value) == 1)
value <- rep(value, length(object))
Expand Down

0 comments on commit 525baaa

Please sign in to comment.