Skip to content

Commit

Permalink
remove part of XML dep
Browse files Browse the repository at this point in the history
  • Loading branch information
lgatto committed Jan 25, 2024
1 parent 44bea3c commit efd48e3
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 28 deletions.
5 changes: 2 additions & 3 deletions DESCRIPTION
@@ -1,6 +1,6 @@
Package: MSnbase
Title: Base Functions and Classes for Mass Spectrometry and Proteomics
Version: 2.29.2
Version: 2.29.3
Description: MSnbase provides infrastructure for manipulation,
processing and visualisation of mass spectrometry and
proteomics data, ranging from raw to quantitative and
Expand Down Expand Up @@ -94,9 +94,9 @@ Imports:
digest,
lattice,
ggplot2,
XML,
scales,
MASS,
XML,
Rcpp
Suggests:
testthat,
Expand Down Expand Up @@ -170,7 +170,6 @@ Collate:
'functions-addIdentificationData.R'
'functions-mzR.R'
'functions-plotting.R'
'header.R'
'hmap.R'
'iPQF.R'
'iTRAQ4.R'
Expand Down
3 changes: 1 addition & 2 deletions NAMESPACE
Expand Up @@ -25,8 +25,7 @@ importFrom(MsCoreUtils, closest, rbindFill,
impute_matrix, normalize_matrix,
robustSummary, medianPolish,
formatRt)
importFrom(XML, xmlInternalTreeParse, getDefaultNamespace, xpathApply,
xmlAttrs)
importFrom(XML, xmlParse, xpathSApply)
importFrom(graphics, abline, axis, grid, legend, lines, points, text,
barplot, layout, par, matplot, mtext)
importFrom(stats, ave, median, medpolish, quantile, reorder, setNames,
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
@@ -1,5 +1,9 @@
# MSnbase 2.29

## MSnbase 2.29.3

- Remove XML dependency.

## MSnbase 2.29.2

- Use fragmentation functions from PSMatch.
Expand Down
15 changes: 0 additions & 15 deletions R/header.R

This file was deleted.

8 changes: 0 additions & 8 deletions tests/testthat/test_MSnExp.R
Expand Up @@ -377,14 +377,6 @@ test_that("phenoData<- on MSnExp works", {
expect_equal(phenoData(im), pd_2)
})

test_that("injection time", {
f <- msdata::proteomics(full.names = TRUE,
pattern = "MS3TMT10_01022016_32917-33481.mzML.gz")
it1 <- MSnbase:::injectionTimeFromFile1(f) ## in millisecs
it2 <- fData(readMSData(f, mode = "onDisk"))$injectionTime ## in millisecs
expect_equal(it1, it2)
})

test_that("chromatogram,MSnExp works", {
inMem <- microtofq_in_mem_ms1
## Reduce here the tests. Most of the tests are performed in
Expand Down

0 comments on commit efd48e3

Please sign in to comment.