Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning empty spectrum when filterMz doesn't select any mz points #134

Closed
lgatto opened this issue Jul 22, 2016 · 3 comments
Closed

Returning empty spectrum when filterMz doesn't select any mz points #134

lgatto opened this issue Jul 22, 2016 · 3 comments

Comments

@lgatto
Copy link
Owner

lgatto commented Jul 22, 2016

Currently, filterMz returns the spectrum as it was when no data points are within minmz and maxmz. I think it would be better to return an empty spectrum, or one with 0 intensity at minmz and maxmz.
@lgatto
Copy link
Owner Author

lgatto commented Jul 22, 2016 •
edited
Loading

Checking with @jotsetung that this is fine. Just close if OK.

lgatto pushed a commit that referenced this issue Jul 22, 2016
@LaurentGatto
returning empty spectrum when fliterMz has empty range - see issue #134
137f7d8
@lgatto
Copy link
Owner Author

lgatto commented Jul 22, 2016

See 137f7d8.

@jorainer
Copy link
Collaborator

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lgatto @jorainer