Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculateFragments calculates too much fragments #248

Closed
sgibb opened this issue Aug 20, 2017 · 0 comments
Closed

calculateFragments calculates too much fragments #248

sgibb opened this issue Aug 20, 2017 · 0 comments
Assignees
Labels

Comments

@sgibb
Copy link
Collaborator

sgibb commented Aug 20, 2017

calculateFragments calculates fragments for all n amino acids in a sequence but only n - 1 bonds are present, so just n - 1 fragments are valid.

E.g. this peptide with 4 amino acids has 3 bonds and valid fragments from a1 to a3 (same for b, c, x, y, z):
fragments

Current output:

calculateFragments("ACE", type="b")
         mz ion type pos z seq
# 1  72.04439  b1    b   1 1   A
# 2 232.07504  b2    b   2 1  AC
# 3 361.11763  b3    b   3 1 ACE

but correct output would be:

calculateFragments("ACE", type="b")
         mz ion type pos z seq
# 1  72.04439  b1    b   1 1   A
# 2 232.07504  b2    b   2 1  AC
@sgibb sgibb added the bug label Aug 20, 2017
@sgibb sgibb self-assigned this Aug 20, 2017
@sgibb sgibb closed this as completed in cca72c6 Aug 20, 2017
sgibb added a commit to sgibb/topdownr that referenced this issue Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant